takraj commented on code in PR #1163:
URL: https://github.com/apache/plc4x/pull/1163#discussion_r1365421995
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
##########
@@ -231,19 +236,21 @@ public Duration getTimeout() {
completionCallback.andThen(handler.getPacketConsumer()),
handler.getOnTimeoutConsumer(),
handler.getErrorConsumer(),
+ handler::confirmHandled,
+ handler::confirmError,
+ handler::cancel,
Review Comment:
Here, a new `HandlerRegistration` is created, copying the original, in order
to inject a `completionCallback` before calling the `packetConsumer`. As
`confirmHandled()` and `cancel()` are called for this new
`HandlerRegistration`, the original one never became done, so
`ConversationContext.isDone()` has never returned `true`.
I'll try to add test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
