chrisdutz commented on PR #1468: URL: https://github.com/apache/plc4x/pull/1468#issuecomment-2022209430
Hi, thank you for adressing part of my comments, however we use Optionals in quite a number of places, so adding the "safe" suffix would not ex expected here. So in general I would propose a name without the "Safe" ending. But the more important thing is, that I think the parseTagAddress methods should probably not be located in the builder, but in the connection ... as I mentioned before, the parseTagAddress method does not change the internal state of the builder, so I guess this is not the right place to it to be located. However your PR did bring up the general question of adding a tagAddress parser method and also start me thinking about the general use of our queryAddress concept ... on the mailinglis I've initated a discussion on using only TagAddress objects and having special Query Tag types for protocols that support that. Chris -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
