sruehl commented on code in PR #1803:
URL: https://github.com/apache/plc4x/pull/1803#discussion_r1794980032
##########
plc4j/drivers/iec-60870/src/test/java/org/apache/plc4x/java/iec608705104/ManualTest.java:
##########
@@ -37,10 +37,10 @@ public static void main(String[] args) throws Exception {
throw new RuntimeException("Subscription not supported");
}
-
plcConnection.subscriptionRequestBuilder().addChangeOfStateTagAddress("all",
"*").addPreRegisteredConsumer("all", plcSubscriptionEvent -> {
+
plcConnection.subscriptionRequestBuilder().addChangeOfStateTagAddress("all",
"*").setConsumer(plcSubscriptionEvent -> {
Review Comment:
shouldn't the consumer be set then as 3rd argument in addEventTagAddress
following that logic? otherwise that would semantical not the same
##########
plc4j/drivers/firmata/src/test/java/org/apache/plc4x/java/firmata/readwrite/FirmataManualTest.java:
##########
@@ -30,7 +30,7 @@ public static void main(String[] args) throws Exception {
// Default for the Firmata Arduino sketch is, 57600 baud, 8 data-bits,
no parity and one stop bit (Which is the default for the Serial transport)
try(PlcConnection connection =
PlcDriverManager.getDefault().getConnectionManager().getConnection("firmata:///dev/tty.usbmodem2114401"))
{
- PlcSubscriptionRequest subscriptionRequest =
connection.subscriptionRequestBuilder().addEventTagAddress("analog1",
"analog:1").addPreRegisteredConsumer("analog1", plcSubscriptionEvent -> {
+ PlcSubscriptionRequest subscriptionRequest =
connection.subscriptionRequestBuilder().addEventTagAddress("analog1",
"analog:1").setConsumer(plcSubscriptionEvent -> {
Review Comment:
shouldn't the consumer be set then as 3rd argument in `addEventTagAddress`
following that logic? otherwise that would semantical not the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
