chrisdutz commented on code in PR #1803:
URL: https://github.com/apache/plc4x/pull/1803#discussion_r1796119032
##########
plc4j/drivers/firmata/src/test/java/org/apache/plc4x/java/firmata/readwrite/FirmataManualTest.java:
##########
@@ -30,7 +30,7 @@ public static void main(String[] args) throws Exception {
// Default for the Firmata Arduino sketch is, 57600 baud, 8 data-bits,
no parity and one stop bit (Which is the default for the Serial transport)
try(PlcConnection connection =
PlcDriverManager.getDefault().getConnectionManager().getConnection("firmata:///dev/tty.usbmodem2114401"))
{
- PlcSubscriptionRequest subscriptionRequest =
connection.subscriptionRequestBuilder().addEventTagAddress("analog1",
"analog:1").addPreRegisteredConsumer("analog1", plcSubscriptionEvent -> {
+ PlcSubscriptionRequest subscriptionRequest =
connection.subscriptionRequestBuilder().addEventTagAddress("analog1",
"analog:1").setConsumer(plcSubscriptionEvent -> {
Review Comment:
That was an example of how to register a handler for all tags of the request
... in that case it was only one, so yes ... there would be no difference to
using the handler registation for an individual tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
