andvasp opened a new pull request, #2039:
URL: https://github.com/apache/plc4x/pull/2039

   Hi everybody!
   
   In this PR I am enabling the AB-Ethernet Driver reading. Also implemented 
the missing multiple tags reading.
   
   I did not change but the transaction counter reinitialize should not be 10 
like the declaration?
   
   [transaction counter 
reinitialize](https://github.com/apache/plc4x/blob/a03d29f4063ace4f63e89b061d87f13a6ae7cc40/plc4j/drivers/ab-eth/src/main/java/org/apache/plc4x/java/abeth/protocol/AbEthProtocolLogic.java#L117)
   ```
       private final AtomicInteger transactionCounterGenerator = new 
AtomicInteger(10);
   ...
     if (transactionCounterGenerator.get() == 0xFFFF) {
         transactionCounterGenerator.set(1);
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to