andvasp opened a new pull request, #2040: URL: https://github.com/apache/plc4x/pull/2040
Hi everybody! In this PR I am enabling the AB-Ethernet Driver reading. Also implemented the missing multiple tags reading. About the transaction counter reinitialization, should not be set to 10 like the declaration? @chrisdutz, Do you remeber why 10? Using one Opc Server it starts with 32. But 10 is working perfectly! [transaction counter reinitialize](https://github.com/apache/plc4x/blob/a03d29f4063ace4f63e89b061d87f13a6ae7cc40/plc4j/drivers/ab-eth/src/main/java/org/apache/plc4x/java/abeth/protocol/AbEthProtocolLogic.java#L117) ``` private final AtomicInteger transactionCounterGenerator = new AtomicInteger(10); ... if (transactionCounterGenerator.get() == 0xFFFF) { transactionCounterGenerator.set(1); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
