Then I withdraw my +1 vote.

Sorry about that Yegor, time for Take 3. If you roll tonight I'll check 
tomorrow.

Regards,
Dave

On Aug 24, 2011, at 3:52 PM, Nick Burch wrote:

> On Wed, 24 Aug 2011, Dave Fisher wrote:
>> RAT reports files that are missing Apache License headers. One or two need 
>> attention. They are in testcases and I am reluctant to call them blockers.
> 
> That's a shame, as I think that missing license headers do generally count as 
> a blocker even on beta releases. Just see general@incubator for many examples 
> of this...

OK.

> 
> I thought I had added something to the release guide about checking rat to 
> avoid this problem (pretty sure it's bitten me too once...!) It's step 7 in 
> the pre-requisite section of the release-guide.txt, but maybe it wants to be 
> moved somewhere else. FWIW, I know of several projects where the rat check is 
> actually part of the dist step, and the dist will abort if the rat check 
> isn't clean, which helps flag it up nice and early!

This was the first time I've used RAT... It will also check signatures, etc.

I think we have been accepting the dummy.txt, *.pen and *.dtd as exceptions.

BTW -

Summary
-------
Notes: 3
Binaries: 119
Archives: 0
Standards: 2768

Apache Licensed: 2746
Generated Documents: 0

JavaDocs are generated and so license header is optional
Generated files do not required license headers

22 Unknown Licenses

*******************************

Unapproved licenses:

  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/contrib/testcases/dummy.txt
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOdia.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOlat1.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOnum.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOpub.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/ISOtech.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/book-cocoon-v10.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/changes-v11.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/document-v11.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/faq-v11.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/javadoc-v04draft.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/dtd/specification-v11.dtd
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOdia.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOgrk1.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOlat1.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOnum.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOpub.pen
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/documentation/content/xdocs/entity/ISOtech.pen
  /Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/examples/lib/dummy.txt
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/dummy.txt
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/log4j.properties
  
/Users/dave/Documents/poi-3.8beta4/poi-3.8-beta4/src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestNumberFormatter.java

*******************************



> 
> Nick
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to