I did run rat-check before Take 1 and fixed a number of issues, see r1156541. But I didn't run it before Take 2, that is why TestNumberFormatter.java cropped up - it was checked-in on Aug 17 , between two takes.
Dave and Nick, Is it really a blocker? Can I have provisional +1 from you, providing that the the problem fixed in trunk ASAP? Otherwise, I'm going to abort the vote and take time to improve the release procedure. If a missing ASF licence header is considered to be a blocker, then rat-check MUST be a part of the "dist" task to prevent such issues in the future. Missing licence in log4.properties is not important, this file is not used and can be dropped. Yegor On Thu, Aug 25, 2011 at 2:52 AM, Nick Burch <nick.bu...@alfresco.com> wrote: > On Wed, 24 Aug 2011, Dave Fisher wrote: >> >> RAT reports files that are missing Apache License headers. One or two need >> attention. They are in testcases and I am reluctant to call them blockers. > > That's a shame, as I think that missing license headers do generally count > as a blocker even on beta releases. Just see general@incubator for many > examples of this... > > I thought I had added something to the release guide about checking rat to > avoid this problem (pretty sure it's bitten me too once...!) It's step 7 in > the pre-requisite section of the release-guide.txt, but maybe it wants to be > moved somewhere else. FWIW, I know of several projects where the rat check > is actually part of the dist step, and the dist will abort if the rat check > isn't clean, which helps flag it up nice and early! > > Nick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
