On Aug 25, 2011, at 3:22 AM, Nick Burch wrote: > On Thu, 25 Aug 2011, Yegor Kozlov wrote: >> Dave and Nick, >> Is it really a blocker? Can I have provisional +1 from you, providing >> that the the problem fixed in trunk ASAP? > > It's certainly a blocker on a final release. On a test file, on a beta > release, I'm less sure
I waver myself. > >> If a missing ASF licence header is considered to be a blocker, then >> rat-check MUST be a part of the "dist" task to prevent such issues in the >> future. > > I'd suggest that if rat isn't present, a warning is raised but the build > continues. The release manager should be instructed to always have Rat > installed. That way, people who take the POI codebase and tweak things can > still do their own custom builds, but we get the check +1 to this. I think reviewers ought to have Rat and Forrest 0.5 installed. We should have improved instructions for release reviewers with example commands. It is cumbersome to deal with the keys and there are missing bits. Let's see if we agree on the steps. (1) Verify artifacts - check signatures and checksums. (2) Check that the zip and tar.gz artifacts unpack to the same content. (3) Perform a full dist build of the source distribution. Check Unit Tests and RAT report. (4) Check docs website from binary distro with built version. Anything else? Regards, Dave > > Nick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
