On Mon, 22 Jul 2013, Darren Roberts wrote:
Having only submitted one very minor patch (54969, but I'm working on a major enhancement to XSSFTextBox at the moment) my opinion probably doesn't count for much, but my vote would be to have a push to include as many of the outstanding patches in bugzilla into a beta2 as possible.
There are a few ways that people can help out with outstanding patches. To maximise the chance of getting it in soon:
If you have submitted a patch - please review it to ensure it applies to the latest version of the code in svn, please ensure any queries on the bug about it are answered, and please make sure it includes a unit test or three
If you use someone else's patch - please let us know that it works and is useful! If you can, please also confirm/fix to work with the latest svn code, and please add in any unit tests it might need
If you have time to help - please pick bugs with patches that look interesting to you. Then, try and apply it to the code from svn, and report back if it still applies. If not, and if you can, please update the patch. Next, with the patch applied, try running any unit tests that the patch comes with. Report if they pass, help to fix them if you can if not. Now, ask questions on any bits of the patch that don't make sense / you think might be better done another way. Finally, add in any more unit tests you think it'd be better with!
If a patch is known to apply to svn, known to work, and has unit tests, it's much easier and quicker for one of the committers to review + commit it, so it's much more likely to get in!
Nick --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
