While we're discussing enums backwards compatibility, are there any other changes as part of https://bz.apache.org/bugzilla/show_bug.cgi?id=59836 that we absolutely cannot break backwards compatibility and blocks 3.16?
58190 <https://bz.apache.org/bugzilla/show_bug.cgi?id=58190>: PictureType (XSLF, scratchpad?) 58636 <https://bz.apache.org/bugzilla/show_bug.cgi?id=58636>: AnchorType (for drawings and comments, SS Common) 58671 <https://bz.apache.org/bugzilla/show_bug.cgi?id=58671>: MissingCellPolicy (class->enum, SS Common) 59264 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59264>: BorderStyle (SS Common) 59790 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59790>: FormulaType (internal, SS Common) ** 59791 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59791>: CellType (SS Common) 59833 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59833>: FillPatternType (for cell background texture, SS Common) 59837 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59837>: HorizontalAlignment and VerticalAlignment (cell style alignment for SS Common) 59873 <https://bz.apache.org/bugzilla/show_bug.cgi?id=59873>: HyperlinkType (Common SS, SL) On Aug 22, 2016 11:27, "Javen O'Neal" <one...@apache.org> wrote: > Nick, could you republish the Javadocs, please? > > On Mon, Aug 22, 2016 at 11:04 AM, Javen O'Neal <one...@apache.org> wrote: > >> switch (cell.getCellType()) { > >> case Cell.CELL_TYPE_NUMERIC: > > > > I have fixed the backwards compatibility problem in r1757235. See [1] > > for more info. > > > > My vote is -1. We should rebuild the RC with r1757235. > > > > I have added this test [2] to prove that the old way of working with > > cell types works without modification alongside the new way. > > > > [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=59791#c10 > > [2] https://svn.apache.org/viewvc/poi/trunk/src/testcases/org/ap > ache/poi/ss/usermodel/BaseTestCell.java?r1=1757235&r2=175723 > 4&pathrev=1757235 > > > > On Mon, Aug 22, 2016 at 8:30 AM, Dominik Stadler <dominik.stad...@gmx.at> > wrote: > >> Hi, > >> > >> Oh, sorry for the false alarm, this seems to be a problem with my > >> compare-tool (Beyond Compare), it displays two test-documents as being > >> contained on top-level of the src-tar.gz. When extracting via other > tools I > >> don't see those. > >> > >> So I am +1 here! > >> > >> However I saw that we do actually break some stuff with all the > >> Enum-rework, e.g. the following will not work any more out of the box: > >> > >> switch (cell.getCellType()) { > >> case Cell.CELL_TYPE_NUMERIC: > >> > >> Unfortunately a switch on teh CellType is quite common, so we need to > >> explain this in the release notes and I think we should be a bit more > >> conservative with all those refactorings/deprecations in the future to > not > >> cause too much change in those places! > >> > >> Dominik. > >> > >> > >> On Mon, Aug 22, 2016 at 11:10 AM, David North <dno...@apache.org> > wrote: > >> > >>> Your image didn't come through. I see the following inside the poi-3.15 > >>> directory of poi-src-3.15-20160828.zip: > >>> > >>> legal > >>> osgi > >>> sonar > >>> src > >>> test-data > >>> build.xml > >>> forrest.properties > >>> KEYS > >>> LICENSE > >>> NOTICE > >>> patch.xml > >>> > >>> Which are unwanted? This seems to match the src packages in the last > beta. > >>> > >>> Thanks, > >>> David > >>> > >>> On 22/08/16 07:47, Dominik Stadler wrote: > >>> > Sorry, me again, > >>> > > >>> > Unfortunately there are still some unwanted artifacts in the > >>> > src-package, can you remove those as well? > >>> > > >>> > > >>> > Inline image 1 > >>> > > >>> > While not blocking the release, but the Java version used for the > build > >>> > seems to be "1.6.0_34", which is a bit outdated, latest (and last) > >>> > version of Java 6 is patchlevel 45, would look better to use this > one to > >>> > build releases. > >>> > > >>> > Dominik. > >>> > > >>> > > >>> > On Mon, Aug 22, 2016 at 12:49 AM, David North <dno...@apache.org > >>> > <mailto:dno...@apache.org>> wrote: > >>> > > >>> > Vote begins now and ends at 11:55 BST 2016-08-23 > >>> > > >>> > Artifacts are here: > >>> > > >>> > https://dist.apache.org/repos/dist/dev/poi/3.15-RC1/ > >>> > <https://dist.apache.org/repos/dist/dev/poi/3.15-RC1/> > >>> > > >>> > Usual checks required (does it work? does the distribution look > >>> right?), > >>> > only more so as this is an RC for a non-beta release. > >>> > > >>> > +1 from me. > >>> > > >>> > As those of you watching the commits may have seen, I can't get > the > >>> svn > >>> > commits from ant to work on either of my machines (Debian stable > or > >>> > Fedora 22) - I thought I'd fixed it by upgrading to svn 1.9, but > >>> > seemingly not. I've therefore replaced them with "exec" tasks > calling > >>> > the SVN command line client. This needs further investigation. > >>> > > >>> > I also had to manually strip out the spurious "trunk" directory > from > >>> the > >>> > src zip/tar, so that's another fix needed somewhere in the build > >>> > scripts. > >>> > > >>> > Thanks, > >>> > > >>> > -- > >>> > David North | www.dnorth.net <http://www.dnorth.net> > >>> > > >>> > > >>> > >>> -- > >>> David North - Committer and PMC Member, Apache POI > >>> https://home.apache.org/~dnorth/ > >>> > >>> >
