That fixed it, thanks. On Sat, Oct 15, 2016 at 2:56 AM, Dominik Stadler <dominik.stad...@gmx.at> wrote:
> There was one leftover file-handle: > > 1 descriptors are open > #1 /tmp/poifiles/poi-sxssf-sheet1825736082761654274.xml by thread:main on > Sat Oct 15 08:09:20 CEST 2016 > at java.io.FileInputStream.<init>(FileInputStream.java:121) > at > org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZipEntrySource. > validateTempFilesAreEncrypted(TestSXSSFWorkbookWithCustomZip > EntrySource.java:136) > > I have fixed this one now via r1765019, please try if tests succeed on > Windows now as well. > > I plan to integrate the file-leak-detection functionality that I use > locally to find such issues easily. > > We also should re-enable running tests on Window-CI-slaves again to catch > such issues in the CI-builds, unfortunately these slaves were rather > unstable in the past, maybe this has improved now. > > Dominik. > > > On Sat, Oct 15, 2016 at 6:29 AM, Mark Murphy <jmarkmur...@gmail.com> > wrote: > > > Windows 7 > > > > svn status contains forrest.properties and src/documentation, svn status > on > > src/documentation is blank. > > > > ant clean jenkins returns the same failure. > > > > thing is it worked a couple days ago. > > > > On Fri, Oct 14, 2016 at 9:59 PM, Javen O'Neal <one...@apache.org> wrote: > > > > > Windows, Linux, or Mac? > > > > > > I know Windows keeps open file handles open, preventing the file from > > being > > > deleted or moved. > > > > > > Does it still break with "ant clean jenkins"? > > > > > > Is "svn status" blank just before running "ant clean jenkins"? > > > > > > On Oct 14, 2016 6:50 PM, "Mark Murphy" <jmarkmur...@gmail.com> wrote: > > > > > > > :ooxml:test > > > > > > > > org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZip > > EntrySource > > > > > > > > validateTempFilesAreEncrypted FAILED > > > > java.lang.AssertionError at > > > > TestSXSSFWorkbookWithCustomZipEntrySource.java:141 > > > > > > > > I think this is just me because I am using a clean download of the > > > project, > > > > and jenkins build is passing. > > > > > > > > So when I debug the junit that is failing, I find that the test that > is > > > > failing is validateTempFilesAreEncrypted, and the failure is that > > > > workbook.dispose is unable to delete the temporary file backing the > > XML. > > > > The only reason that could be is that the test still has the file > open > > at > > > > the time it is attempting to delete it. I tried to delete the file > > > manually > > > > while the program is at the breakpoint, and I cannot. But once the > test > > > has > > > > completed, I am able to manually delete the file. Maybe the close on > > the > > > > Writer is failing silently, or something else has the file open. I > > don't > > > > understand why this would be happening though as the jenkins build > does > > > not > > > > detect this (on the server). > > > > > > > > It did work for me a couple days ago when I was preparing to commit > my > > > > patch. I have nothing else in the works right now though since I > can't > > > even > > > > build the project with a clean install. > > > > > > > > > >
