jlolling commented on PR #528: URL: https://github.com/apache/poi/pull/528#issuecomment-1752856333
I will try to add a test case I will also fix the typos but they are not caused by me. > On 9. Oct 2023, at 13:43, PJ Fanning ***@***.***> wrote: > > > @pjfanning requested changes on this pull request. > > Can you add a test case? > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350192943>: > > > @@ -1145,7 +1152,7 @@ public boolean isDisplayRowColHeadings() { > * Breaks occur above the specified row and left of the specified column inclusive. > * > * For example, ***@***.*** sheet.setColumnBreak(2);} breaks the sheet into two parts > - * with columns A,B,C in the first and D,E,... in the second. Similar, ***@***.*** sheet.setRowBreak(2);} > + * with columns A,B,C in the first and D,E,... in the second. Simuilar, ***@***.*** sheet.setRowBreak(2);} > Can you fix the typo here? > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350194065>: > > > } > > /** > - * Ungroup a range of columns that were previously grouped > + * Ungroup a range of columns that were previously groupped > another typo - please do not give us PRs where you randomly change code unrelated to your fix > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350194317>: > > > @@ -1240,11 +1247,11 @@ public void setColumnGroupCollapsed(int columnNumber, boolean collapsed) { > */ > @Override > public void groupColumn(int fromColumn, int toColumn) { > - _sh.groupColumn(fromColumn, toColumn); > why are you reformatting this code? > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350194811>: > > > */ > @Override > public void setRowGroupCollapsed(int row, boolean collapse) { > if (collapse) { > collapseRow(row); > } else { > //expandRow(rowIndex); > - throw new IllegalStateException("Unable to expand row: Not Implemented"); > + throw new RuntimeException("Unable to expand row: Not Implemented"); > please do not change the exception type > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/poi/pull/528#pullrequestreview-1664263448>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5KS7OWFL2WUVNSV4PJURLX6PPPBAVCNFSM6AAAAAA5YVCZFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRUGI3DGNBUHA>. > You are receiving this because you modified the open/close state. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
