jlolling commented on PR #528: URL: https://github.com/apache/poi/pull/528#issuecomment-1752859725
I have not “randomly” changed code. I have started from a code some weeks earlier. I will rebase my branch and continue. > On 9. Oct 2023, at 13:44, PJ Fanning ***@***.***> wrote: > > > @pjfanning commented on this pull request. > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350196110>: > > > @@ -61,11 +62,7 @@ protected SXSSFSheet(SXSSFWorkbook workbook, XSSFSheet xSheet, int randomAccessW > _sh = xSheet; > calculateLeftAndRightMostColumns(xSheet); > setRandomAccessWindowSize(randomAccessWindowSize); > - try { > - _autoSizeColumnTracker = new AutoSizeColumnTracker(this); > - } catch (UnsatisfiedLinkError | InternalError e) { > - LOG.atWarn().log("Failed to create AutoSizeColumnTracker, possibly due to fonts not being installed in your OS", e); > - } > + _autoSizeColumnTracker = new AutoSizeColumnTracker(this); > please do not randomly change code like this- undo this change or the PR is rejected > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/poi/pull/528#pullrequestreview-1664268560>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5KS7P7KN4QKA6Y6X6HEB3X6PPR7AVCNFSM6AAAAAA5YVCZFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRUGI3DQNJWGA>. > You are receiving this because you modified the open/close state. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
