jlolling commented on PR #528: URL: https://github.com/apache/poi/pull/528#issuecomment-1752888018
I will remove my name and set the ticket number instead. OK? > On 9. Oct 2023, at 14:06, PJ Fanning ***@***.***> wrote: > > > @pjfanning commented on this pull request. > > In poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java <https://github.com/apache/poi/pull/528#discussion_r1350219068>: > > > @@ -191,8 +192,13 @@ public void removeRow(Row row) { > * @return Row representing the rownumber or null if its not defined on the sheet > */ > @Override > - public SXSSFRow getRow(int rownum) { > - return _rows.get(rownum); > + public Row getRow(int rownum) { > + Row row = _rows.get(rownum); > + // jlolling: allow reading all the content > In the ASF, we believe in shared ownership of the code. Please do not annotate code with your name. > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/poi/pull/528#pullrequestreview-1664305048>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5KS7OVGRS45UHBJ7OJ7ALX6PSETAVCNFSM6AAAAAA5YVCZFSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRUGMYDKMBUHA>. > You are receiving this because you modified the open/close state. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
