tballison opened a new pull request, #1492:
URL: https://github.com/apache/poi/pull/1492
My :robot: came up with this small tweak. Let me know what you think.
```
Below the Integer.MAX_VALUE threshold, numerator overflow in
SimpleFraction fell back to a
coarse convergent: "?????????/?????????" showed 2.1e9 + 0.123456789 as
2100000000/1. The
closest fraction to v - floor(v) with a given maximum denominator is the
closest to v, less
floor(v), so splitting always gives the same fraction without the overflow.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
