pjfanning commented on PR #1492: URL: https://github.com/apache/poi/pull/1492#issuecomment-6424325367
A correction to my review: Excel also gives `2100000000/1` for `=TEXT(2100000000.12345,"?????????/?????????")`, so the output before this PR matches Excel there too. Excel gives the same results as the old code for all three values (`202510/81`, `2435705741/8119`, `2100000000/1`), so I don't think the precision change should go in. The `NaN` issue doesn't exist on trunk, because it only appears with the unconditional split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
