pjfanning commented on PR #1492: URL: https://github.com/apache/poi/pull/1492#issuecomment-6424418500
Correcting my last comment: trunk does **not** match Excel for 300000.707106781. Trunk gives `1008902378/3363`, and Excel gives `2435705741/8119`. The numerator overflows an int before the denominator reaches 8119. So there is a real trunk bug for values like this one, but a fix needs to stop where Excel stops, not use the full 9-digit denominator. The other two values (`202510/81` and `2100000000/1`) do match Excel on trunk. All three are now tests in #1493, with the 300000.x case `@Disabled`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
