Hi eric.bachard,

On Wed, May 11, 2005 at 14:39:13 +0200, eric.bachard wrote:

> As suggested by Eicke Ratcke,

May I insist on spelling my name correctly? ;-)

> I have made a change in psprint, using 
> rtl/math.hxx, replacing a hack.
> This change, already working on Mac OSX 10.3/10.4 needs absolutly to be 
> tested on all platforms and OS because it can break the build in psprint.

Removing the inclusion of math.h might cause trouble on other platforms
if they need it for finite() or other declarations. Things vary between
platforms.

While people are at it, could someone running FreeBSD check whether
removing also

#if defined (FREEBSD)
using namespace __gnu_cxx;  //for isnan #iz27753 for FreeBSD
#endif

would break anything? Maybe the namespace is needed also for the
finite() call used in that file, which btw could be replaced by
::rtl::math::isFinite() instead if causing trouble. As that is used in
the string/double conversion routines which are somewhat code
duplications of equivalent rtl::math::* methods I filed
http://qa.openoffice.org/issues/show_bug.cgi?id=49079
to replace them entirely.

  Eike

-- 
 OOo/SO Calc core developer. Number formatter bedevilled I18N transpositionizer.
 GnuPG key 0x293C05FD:  997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to