Hi,
Eike Rathke a �crit :
May I insist on spelling my name correctly? ;-)
I'm confused. Please excuse me :-/
I have made a change in psprint, using rtl/math.hxx, replacing a hack.
This change, already working on Mac OSX 10.3/10.4 needs absolutly to be tested on all platforms and OS because it can break the build in psprint.
Removing the inclusion of math.h might cause trouble on other platforms if they need it for finite() or other declarations.
Ah ...and can the use of ::rtl::math::isFinite() , replacing finite() solve this ? (for every platform)
Things vary between
platforms.
Other question: is finite() alone in the list, or are other calls involved ? I just see some math functions in strhelper.cxx, and the list seems to be very limited.
While people are at it, could someone running FreeBSD check whether removing also
#if defined (FREEBSD) using namespace __gnu_cxx; //for isnan #iz27753 for FreeBSD #endif
would break anything? Maybe the namespace is needed also for the finite() call used in that file, which btw could be replaced by ::rtl::math::isFinite() instead if causing trouble.
I think Maho will test soon.
As that is used in
the string/double conversion routines which are somewhat code duplications of equivalent rtl::math::* methods I filed
http://qa.openoffice.org/issues/show_bug.cgi?id=49079 to replace them entirely.
The first time I have read the content of #i49079#, I thought it was a duplicate, but now, I understand this is more important ... And if I read correctly, the changes made in #i48845# (ie macosx07 part) are not complete, or must be removed, for portabilities reasons, right ?
Regards, eric bachard
--
eric bachard <[EMAIL PROTECTED]>
Francophone OpenOffice.org Commmunity developer (Linux PPC / Mac OS X / X11)
See : <http://fr.openoffice.org>
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
