Hi eric.bachard, On Thu, May 12, 2005 at 01:48:37 +0200, eric.bachard wrote:
> >May I insist on spelling my name correctly? ;-) > I'm confused. Please excuse me :-/ No problem ;) > >Removing the inclusion of math.h might cause trouble on other platforms > >if they need it for finite() or other declarations. > > Ah ...and can the use of ::rtl::math::isFinite() , replacing finite() > solve this ? (for every platform) Yes. If math.h isn't needed for anything else in that file, I didn't check that, but it didn't look like by browsing through. > >http://qa.openoffice.org/issues/show_bug.cgi?id=49079 > >to replace them entirely. > > The first time I have read the content of #i49079#, I thought it was a > duplicate, but now, I understand this is more important ... And if I > read correctly, the changes made in #i48845# (ie macosx07 part) are not > complete, or must be removed, for portabilities reasons, right ? ?? why should the changes be removed? Replacing isnan() by ::rtl::math::isNan() solves porting issues, as may the replacement of finite() with ::rtl::math::isFinite() though it seems there weren't any issues with that by now. Issue 49079 is about replacing the entire string/double conversion code with calls to analogous functions in ::rtl::math, but that is not relevant for porting right now, it only would remove duplicated code and assure that if there were any porting issues in future they could be fixed in one central place. Eike -- OOo/SO Calc core developer. Number formatter bedevilled I18N transpositionizer. GnuPG key 0x293C05FD: 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
