jiridanek commented on pull request #2: URL: https://github.com/apache/qpid-protonj2/pull/2#issuecomment-904718155
Few examples of what it reports, from https://github.com/apache/qpid-protonj2/runs/3412406596 ``` Warning: /home/runner/work/qpid-protonj2/qpid-protonj2/protonj2-test-driver/src/main/java/org/apache/qpid/protonj2/test/driver/codec/transport/Attach.java:[273,16] [FallThrough] Execution may fall through from the previous case; add a `// fall through` comment before this line if it was deliberate (see https://errorprone.info/bugpattern/FallThrough) ``` ``` Warning: /home/runner/work/qpid-protonj2/qpid-protonj2/protonj2/src/main/java/org/apache/qpid/protonj2/types/transport/ReceiverSettleMode.java:[25,25] [ImmutableEnumChecker] enums should be immutable: 'ReceiverSettleMode' has non-final field 'value' (see https://errorprone.info/bugpattern/ImmutableEnumChecker) Did you mean 'private final UnsignedByte value;'? ``` ``` Warning: /home/runner/work/qpid-protonj2/qpid-protonj2/protonj2/src/main/java/org/apache/qpid/protonj2/engine/impl/ProtonEndpoint.java:[63,17] [TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution. 2219 (see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
