jiridanek commented on pull request #2: URL: https://github.com/apache/qpid-protonj2/pull/2#issuecomment-906726522
> These tools can be useful when run from an IDE or something but I don't tend to find them useful in the maven build and especially errorprone which tends to break more often than provide useful results vs just a ton of warnings that don't actually point to any real issues that require constant babysitting Error Prone works quite well in an IDE. It emits compiler warnings, and IDEs are good at showing compiler warnings and making them clickable and navigable. So having the errorprone as an optional maven profile, with the nuisance noisy checks disabled in pom.xml can be reasonably convenient, assuming that there is an useful set of checks. If all checks are made to be warnings by default, and possibly only a select few of reliable checks are explicitly set as errors, that should minimize the amount of babysitting required. I consider this mostly a friendly feature for drive-by contributors: yay, some checker passed on my change! Of course, this requires that there is actually an errorprone checks that you care about enforcing. Over all, I am currently most in favor of coverity, plus possibly running infer from time to time, manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
