alex-rufous commented on a change in pull request #113:
URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r740212386
##########
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##########
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+ else if (property == Property.CONNECTION_LIMIT)
+ {
+ LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##########
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##########
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+ else if (property == Property.CONNECTION_LIMIT)
+ {
+ LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
+ return false;
+ }
+ else if (property == Property.CONNECTION_FREQUENCY_LIMIT)
+ {
+ LOGGER.warn("The ACL Rule property 'connection_frequency_limit'
has been deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##########
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/RulePredicate.java
##########
@@ -62,5 +71,16 @@ public boolean matches(LegacyOperation operation,
ObjectProperties objectPropert
return true;
}
+ @Override
+ public RulePredicate and(RulePredicate other)
Review comment:
IMHO, this breaks a semantic of logical and,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
