mklaca commented on pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#issuecomment-961997263
Hi Alex, regarding the RulePredicate.Any performance optimization, I have measured the impact of the chain of rule predicates optimization on the performance. The time of ACL rules check decreases by 2-3%, it depends on the structure of ACL rules of course. But the optimization has always a positive impact. The whole ACL plugin performance optimization is based on the set of many small improvements that together will improve the performance significantly. I disagree that > The code readability has improved significantly without additional "any" check From my point of view, it is a small change and it allows "null check free code". The RulePredicate.Any can be used as the default value instead of null and so it could be added to the predicate chain multiple times and any null check is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
