kgiusti commented on a change in pull request #1437:
URL: https://github.com/apache/qpid-dispatch/pull/1437#discussion_r750616680
##########
File path: tests/system_tests_edge_router.py
##########
@@ -1895,6 +1895,10 @@ def test_51_link_route_proxy_configured(self):
if self.skip['test_51'] :
self.skipTest("Test skipped during development.")
+ # The previous test waited for address CfgLinkRoute1 on router INT_B
+ # We will wait for address CfgLinkRoute1 to be unsubscribed
+ self.INT_B.wait_address_unsubscribed("CfgLinkRoute1")
Review comment:
I agree with @jiridanek that the proper fix would to require each test
to wait until all addresses introduced by the test have been purged from all
the routers. But only having one test do this which happens to be ordered
before the failing test is brittle in that there's nothing stopping some poor
unfortunate dev from re-naming tests and inadvertently re-breaking this
particular test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
