jiridanek commented on a change in pull request #1437:
URL: https://github.com/apache/qpid-dispatch/pull/1437#discussion_r750624452



##########
File path: tests/system_tests_edge_router.py
##########
@@ -1895,6 +1895,10 @@ def test_51_link_route_proxy_configured(self):
         if self.skip['test_51'] :
             self.skipTest("Test skipped during development.")
 
+        # The previous test waited for address CfgLinkRoute1 on router INT_B
+        # We will wait for address CfgLinkRoute1 to be unsubscribed
+        self.INT_B.wait_address_unsubscribed("CfgLinkRoute1")

Review comment:
       Another way, maybe not quick, but certainly dirty, would be to require 
that each test suffixes all addresses it uses with it's own name. The name can 
be found by introspecting the Python stack, or maybe the unittest module 
already knows the name of the currently running test. Randomly generated string 
would work as well.
   
   The problem is that these unique addresses cannot be preconfigured ar the 
beginning, each test has to create them through management.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to