jiridanek commented on a change in pull request #356:
URL: https://github.com/apache/qpid-proton/pull/356#discussion_r799395097
##########
File path: python/setup.py.in
##########
@@ -145,6 +146,7 @@ class Configure(build_ext):
# pkg-config for a minimum version 0. If it's installed, it should
# return True and we'll use it. Otherwise, we'll use the stub.
if misc.pkg_config_version_installed('openssl', atleast='0'):
+ library_dirs += [misc.pkg_config_get_var('openssl', 'libdir')]
libraries += ['ssl', 'crypto']
Review comment:
This actually makes a little bit of sense to me. `ssl` and `crypto` are
essentially components of OpenSSL that user chooses to pull in or not. So the
line is similar to
```
find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
```
where Dispatch also explicitly specifies the names of components, instead of
asking the lib for all components available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
