jiridanek commented on code in PR #371:
URL: https://github.com/apache/qpid-proton/pull/371#discussion_r875935877
##########
c/src/ProtonConfig.cmake.in:
##########
@@ -52,26 +52,38 @@ if (Proton_USE_STATIC_LIBS)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH_OLD})
endif()
-set (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@)
+set_and_check (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@)
Review Comment:
`set_and_check` is documented in
https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html, they
say it should be used for variables that hold paths; I know it is unrelated,
but it is also not worth its own commit, seemed to me; I can split it out as
its own PR if you think it helps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
