jiridanek commented on code in PR #371: URL: https://github.com/apache/qpid-proton/pull/371#discussion_r875936714
########## c/src/ProtonConfig.cmake.in: ########## @@ -52,26 +52,38 @@ if (Proton_USE_STATIC_LIBS) set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH_OLD}) endif() -set (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@) +set_and_check (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@) Review Comment: and, yeah, I forgot that gh ci does not have centos, I need to check old cmake can do this old cmake knows this, good ########## c/src/ProtonConfig.cmake.in: ########## @@ -52,26 +52,38 @@ if (Proton_USE_STATIC_LIBS) set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH_OLD}) endif() -set (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@) +set_and_check (Proton_INCLUDE_DIRS @PACKAGE_INCLUDE_INSTALL_DIR@) Review Comment: and, yeah, I forgot that gh ci does not have centos, I need to check old cmake can do this edit: old cmake knows this, good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org