----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/627/#review501 -----------------------------------------------------------
Ship it! The code looks OK, but do we really need to worry about people setting a TTL of more than 17 billion years? - Alan On 2011-04-20 16:47:00, Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/627/ > ----------------------------------------------------------- > > (Updated 2011-04-20 16:47:00) > > > Review request for qpid, Andrew Stitcher, Alan Conway, Chug Rolke, and Steve > Huston. > > > Summary > ------- > > Fixes ttl overflow on the broker. Added equality operator for > qpid::messaging::Duration (needed it in test and seemed generally valuable). > > > This addresses bug QPID-3222. > https://issues.apache.org/jira/browse/QPID-3222 > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/messaging/Duration.h 1090157 > /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1090157 > /trunk/qpid/cpp/src/qpid/messaging/Duration.cpp 1090157 > /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1090157 > > Diff: https://reviews.apache.org/r/627/diff > > > Testing > ------- > > New test added, make check passes. > > > Thanks, > > Gordon > >
