On 04/20/2011 01:14 PM, Gordon Sim wrote:
On 2011-04-20 16:59:07, Alan Conway wrote:
The code looks OK, but do we really need to worry about people setting a TTL of
more than 17 billion years?
Alan Conway wrote:
Actually looking at the BZ, the real issue is giving FOREVER the correct
special treatment at each step, it's not really an overflow issue at all.
FOREVER is indeed the most important case. However as the value on the wire is
uint64 (and is in ms), we need to make sure that no positive value that is sent
is turned into a negative value and thus immediately marks the messages as
expired. It is indeed very unlikely that anyone would have a real need to use
anything other than FOREVER that would cause this, but other values could
trigger the same thing, so why not fix the overflow entirely.
Agreed, it does no harm.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
