[
https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080882#comment-13080882
]
jirapos...@reviews.apache.org commented on QPID-3346:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1312/#review1317
-----------------------------------------------------------
/branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp
<https://reviews.apache.org/r/1312/#comment2990>
Not too keen on this lookup. Can it be avoided?
E.g. can we modify the Queue::acquire() to simply take the consumer name as
the second parameter? (That is for the present at least all that is required)
Alternatively the DeliveryRecord could be modified to hold a pointer to the
Consumer rather than simply the tag.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp
<https://reviews.apache.org/r/1312/#comment2991>
The purpose of the check is to ensure that an acquire attempt for a message
that has since been replaced, does not acquire the message that has replaced it
instead.
I believe it is still necessary, though I concede the form is ugly and
unintuitive.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h
<https://reviews.apache.org/r/1312/#comment2992>
I'm not keen on the terminology here. For me selector implies something
subtly different from the role this object is serving (at least from the role I
*think* it is serving).
I'd prefer something like 'allocator'.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h
<https://reviews.apache.org/r/1312/#comment2993>
Again, I'm not too keen on the term 'consumed' in this context. Though I
can see how it is justified, it is potentially confusing in my view (could
imply the actual dequeue of a message).
I'd prefer 'acquired', 'allocated' or even just 'locked' as they are all
less ambiguous on the state in question.
- Gordon
On 2011-08-05 20:46:15, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1312/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-05 20:46:15)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Some initial refactoring of Queue/Consumer interface to allow for message
grouping support. Very preliminary.
bq.
bq.
bq. This addresses bug qpid-3346.
bq. https://issues.apache.org/jira/browse/qpid-3346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144324
bq.
bq. Diff: https://reviews.apache.org/r/1312/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. minimal - passes unit tests on linux.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Support message grouping with stricted sequence consumption across multiple
> consumers.
> --------------------------------------------------------------------------------------
>
> Key: QPID-3346
> URL: https://issues.apache.org/jira/browse/QPID-3346
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.14
>
> Attachments: msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced
> Consumers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
