[
https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085705#comment-13085705
]
jirapos...@reviews.apache.org commented on QPID-3346:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1312/#review1473
-----------------------------------------------------------
/branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp
<https://reviews.apache.org/r/1312/#comment3380>
Honestly, I have no idea! Probably something I changed but didn't
completely revert - I'll remove it.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h
<https://reviews.apache.org/r/1312/#comment3381>
Not _really_ - the message group's getNextMessage() method uses it, so it
really only applies to FIFO queues (not LVQs). And, because FIFO's are
ordered by sequence number only, it can go away.
I had added it to support my initial approach to support a Queue's
move/reroute/purge, which I refactored to use foreach as per your suggestion.
A much cleaner approach, btw.
I'll remove this.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h
<https://reviews.apache.org/r/1312/#comment3382>
Agreed - I don't like adding "type" info here, as it would probably be
abused. You are correct - I wanted to validate the config, and added this to
simplify the code.
I'll back it out and specifically check the settings map for incompatible
options.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/1312/#comment3383>
This is the default group identifier that would be applied to messages that
arrive at the grouped queue _without_ containing a group identifier header.
Enforces the requirement that all "ungrouped" messages are treated as
belonging to the same default group.
/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/1312/#comment3384>
Originally tried that, but the eventual call to acquire() would fail as the
message was already removed from the queue (we need to call acquire/dequeue to
maintain correct state).
I can use removeIf, but I'll have to provide a variant of acquire() that
assumes the message has already been removed from the queue.
- Kenneth
On 2011-08-16 00:35:20, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1312/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-16 00:35:20)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Some initial refactoring of Queue/Consumer interface to allow for message
grouping support. Very preliminary.
bq.
bq.
bq. This addresses bug qpid-3346.
bq. https://issues.apache.org/jira/browse/qpid-3346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Fairshare.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Messages.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144319
bq. /branches/qpid-3346/qpid/specs/management-schema.xml 1144324
bq.
/branches/qpid-3346/qpid/tests/src/py/qpid_tests/broker_0_10/management.py
1144324
bq.
bq. Diff: https://reviews.apache.org/r/1312/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. minimal - passes unit tests on linux.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Support message grouping with stricted sequence consumption across multiple
> consumers.
> --------------------------------------------------------------------------------------
>
> Key: QPID-3346
> URL: https://issues.apache.org/jira/browse/QPID-3346
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.14
>
> Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced
> Consumers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
