[
https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085719#comment-13085719
]
jirapos...@reviews.apache.org commented on QPID-3346:
-----------------------------------------------------
bq. On 2011-08-16 13:56:46, Kenneth Giusti wrote:
bq. > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h, line 419
bq. > <https://reviews.apache.org/r/1312/diff/2/?file=32699#file32699line419>
bq. >
bq. > Agreed - I don't like adding "type" info here, as it would probably
be abused. You are correct - I wanted to validate the config, and added this
to simplify the code.
bq. >
bq. > I'll back it out and specifically check the settings map for
incompatible options.
Perhaps what we want here is a QueueConfiguration class that is an internal
only, strongly typed, explicitly named set of configuration options. We would
create this from the arguments specified in one place (within this class
itself), and then all other decisions based on configuration could use the
simpler, more explicit interface. What do you think?
bq. On 2011-08-16 13:56:46, Kenneth Giusti wrote:
bq. > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp, line 660
bq. > <https://reviews.apache.org/r/1312/diff/2/?file=32700#file32700line660>
bq. >
bq. > Originally tried that, but the eventual call to acquire() would fail
as the message was already removed from the queue (we need to call
acquire/dequeue to maintain correct state).
bq. >
bq. > I can use removeIf, but I'll have to provide a variant of acquire()
that assumes the message has already been removed from the queue.
bq. >
bq. >
Ah, yes I see what you mean... I was confusing Messages::remove() and
Queue::acquire() there for a minute...
That said however, is much of Queue::acquire() not actually irrelevant here
(i.e. in purge/move/reroute) anyway? We don't actually want to check whether we
can acquire the message. All we need to do (other than remove it from messages)
is notify the observers. Or am I missing something?
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1312/#review1473
-----------------------------------------------------------
On 2011-08-16 00:35:20, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1312/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-16 00:35:20)
bq.
bq.
bq. Review request for qpid.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Some initial refactoring of Queue/Consumer interface to allow for message
grouping support. Very preliminary.
bq.
bq.
bq. This addresses bug qpid-3346.
bq. https://issues.apache.org/jira/browse/qpid-3346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Fairshare.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Messages.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.h 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1144324
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144319
bq. /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144319
bq. /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144319
bq. /branches/qpid-3346/qpid/specs/management-schema.xml 1144324
bq.
/branches/qpid-3346/qpid/tests/src/py/qpid_tests/broker_0_10/management.py
1144324
bq.
bq. Diff: https://reviews.apache.org/r/1312/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. minimal - passes unit tests on linux.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Support message grouping with stricted sequence consumption across multiple
> consumers.
> --------------------------------------------------------------------------------------
>
> Key: QPID-3346
> URL: https://issues.apache.org/jira/browse/QPID-3346
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.14
>
> Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced
> Consumers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
