> On 2012-05-03 16:17:15, Andrew Stitcher wrote: > > I'm concerned that using a simple IP address approach to avoiding > > connecting to yourself also stops you testing (or deploying) using multiple > > brokers on the same host.
Good point, I'll use host:port - no changed needed in isLocalHost though, I will put the port test higher up. > On 2012-05-03 16:17:15, Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp, line 111 > > <https://reviews.apache.org/r/4992/diff/1/?file=106374#file106374line111> > > > > Don't use gethostbyname(), it's obsolete (and has been for over 10 > > years) it's also not threadsafe. Use getaddrinfo() Will do. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7503 ----------------------------------------------------------- On 2012-05-03 15:57:01, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4992/ > ----------------------------------------------------------- > > (Updated 2012-05-03 15:57:01) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Summary > ------- > > Need by the new HA work to avoid connections to self. > - needs windows implementation > - doesn't cover ipv6, neither does other Url handling code at this point > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1333473 > /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp 1333473 > /trunk/qpid/cpp/src/qpid/sys/windows/SystemInfo.cpp 1333473 > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1333473 > /trunk/qpid/cpp/src/tests/Makefile.am 1333473 > /trunk/qpid/cpp/src/tests/SystemInfo.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4992/diff > > > Testing > ------- > > New unit test/SystemInfo.cpp. > make check passes > > > Thanks, > > Alan > >
