----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7510 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp <https://reviews.apache.org/r/4992/#comment16633> memory leak - result is never freed with freeaddrinfo /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp <https://reviews.apache.org/r/4992/#comment16634> Not sure it's a big issue, but the algorithm here is order N^2 in number of addresses /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp <https://reviews.apache.org/r/4992/#comment16632> Some funny formatting thing going on here - Andrew On 2012-05-03 18:07:53, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4992/ > ----------------------------------------------------------- > > (Updated 2012-05-03 18:07:53) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Summary > ------- > > Need by the new HA work to avoid connections to self. > - needs windows implementation > - doesn't cover ipv6, neither does other Url handling code at this point > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1333473 > /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp 1333473 > /trunk/qpid/cpp/src/qpid/sys/windows/SystemInfo.cpp 1333473 > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1333473 > /trunk/qpid/cpp/src/tests/Makefile.am 1333473 > /trunk/qpid/cpp/src/tests/SystemInfo.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4992/diff > > > Testing > ------- > > New unit test/SystemInfo.cpp. > make check passes > > > Thanks, > > Alan > >
