----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7647 -----------------------------------------------------------
Ship it! - Andrew On 2012-05-07 17:00:08, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4992/ > ----------------------------------------------------------- > > (Updated 2012-05-07 17:00:08) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Summary > ------- > > Need by the new HA work to avoid connections to self. > - needs windows implementation > - doesn't cover ipv6, neither does other Url handling code at this point > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1335016 > /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp 1335016 > /trunk/qpid/cpp/src/qpid/sys/windows/SystemInfo.cpp 1335016 > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1335016 > /trunk/qpid/cpp/src/tests/Makefile.am 1335016 > /trunk/qpid/cpp/src/tests/SystemInfo.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4992/diff > > > Testing > ------- > > New unit test/SystemInfo.cpp. > make check passes > > > Thanks, > > Alan > >
