----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15803 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp <https://reviews.apache.org/r/9137/#comment34013> Don't do this! If there's not an error don't allow the exception to propagate here in the first place. I don't want exceptions that aren't really exceptional ending up here, which is the import of this change. - Andrew Stitcher On Jan. 29, 2013, 8:01 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9137/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 8:01 p.m.) > > > Review request for qpid and Andrew-Duplicate-Accct-Inactiv Konwinski. > > > Description > ------- > > Sporadic failure of test_failover_python was caused by a race in rejecting > connections. There was a very small window where work could be done by a > connection after it was rejected. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/ha/BackupConnectionExcluder.h 1439431 > /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.h 1439431 > /trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp 1439431 > /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1439431 > > Diff: https://reviews.apache.org/r/9137/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
