> On Jan. 29, 2013, 9:59 p.m., Andrew Stitcher wrote:
> > /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp, line 99
> > <https://reviews.apache.org/r/9137/diff/2/?file=253082#file253082line99>
> >
> > I don't think this should be protected by !readError as the read and
> > write sides are independent.
> >
> > [Although it may well be impossible to get an abort if we've previously
> > got a readError]
Done, now reads:
if (!readError) {
aio->requestCallback(boost::bind(&AsynchIOHandler::eof, this, _1));
}
aio->queueWriteClose();
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9137/#review15809
-----------------------------------------------------------
On Jan. 29, 2013, 9:49 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9137/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 9:49 p.m.)
>
>
> Review request for qpid and Andrew-Duplicate-Accct-Inactiv Konwinski.
>
>
> Description
> -------
>
> HA Fix race condition in rejecting connections.
>
> Sporadic failure of test_failover_python was caused by a race in rejecting
> connections. There was a very small window where work could be done by a
> connection after it was rejected.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1439431
>
> Diff: https://reviews.apache.org/r/9137/diff/
>
>
> Testing
> -------
>
> make check, manual heartbeat test
>
>
> Thanks,
>
> Alan Conway
>
>
