----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9137/#review15837 -----------------------------------------------------------
Is abort() the right call to make? What about close()? It looks to me like the 'purpose' of abort is to trigger a simulated eof call on the connection processing thread from e.g. the heartbeat timer thread. Since in this case we are already on the connection processing thread, why would close() not do the job (this is not the same as issuing a clean connection.close sequence I don't believe). One thing to remember with any change to the IO code is that different 'transports' (ssl, rdma) and platforms (windows) may involve different codepaths. - Gordon Sim On Jan. 29, 2013, 9:49 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9137/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 9:49 p.m.) > > > Review request for qpid and Andrew-Duplicate-Accct-Inactiv Konwinski. > > > Description > ------- > > HA Fix race condition in rejecting connections. > > Sporadic failure of test_failover_python was caused by a race in rejecting > connections. There was a very small window where work could be done by a > connection after it was rejected. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1439431 > > Diff: https://reviews.apache.org/r/9137/diff/ > > > Testing > ------- > > make check, manual heartbeat test > > > Thanks, > > Alan Conway > >
