----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10872/#review20068 -----------------------------------------------------------
Ship it! Fine by me (I'm also happy with Andrew's more general 'disable listen' solution though I have posted one question on that). /trunk/qpid/cpp/src/posix/QpiddBroker.cpp <https://reviews.apache.org/r/10872/#comment41310> Minor: seem to have an unintentional line break here. - Gordon Sim On May 1, 2013, 6:18 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10872/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 6:18 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0' > > qpidd-p0 script binds a new port to a socket using bind(0), and then > execs qpidd using the --socket-fd option to pass the socket to qpidd. > > New broker option --tcp-listen can disable TCP listening when using > --socket-fd. > > Fixed qpidd port printing logic: print port only if --port=0, regardless of > --transport. > > > Diffs > ----- > > /trunk/qpid/cpp/src/posix/QpiddBroker.cpp 1478115 > /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1478115 > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1478115 > /trunk/qpid/cpp/src/tests/brokertest.py 1478115 > /trunk/qpid/cpp/src/tests/ha_tests.py 1478115 > /trunk/qpid/cpp/src/tests/qpidd-p0 PRE-CREATION > > Diff: https://reviews.apache.org/r/10872/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alan Conway > >
