----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10872/#review20098 -----------------------------------------------------------
Ship it! I think there is now a lot more in the diff than is really in the change. But I think it looks good. - Andrew Stitcher On May 2, 2013, 9:35 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10872/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 9:35 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0' > > qpidd-p0 script binds a new port to a socket using bind(0), and then > execs qpidd using the --socket-fd option to pass the socket to qpidd. > > Changes: > - Added qpidd-p0 > - Fixed qpidd port printing logic: print port only if --port=0, regardless of > --transport. > - New option --listen-disable to disable specific transport listeners. > > WIP: astitcher disable-transpor from https://reviews.apache.org/r/10894/ > > > Diffs > ----- > > /trunk/qpid/cpp/src/posix/QpiddBroker.cpp 1478313 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1478313 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1478313 > /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1478313 > /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1478313 > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1478313 > /trunk/qpid/cpp/src/tests/Makefile.am 1478313 > /trunk/qpid/cpp/src/tests/qpidd-p0 PRE-CREATION > > Diff: https://reviews.apache.org/r/10872/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alan Conway > >
