----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10872/ -----------------------------------------------------------
(Updated May 2, 2013, 9:35 p.m.) Review request for qpid, Andrew Stitcher and Gordon Sim. Changes ------- Using Andrew's --listen-disable flag. I have a reproducer that gives the "address in use" error within 5 mins on trunk, with the qpidd-p0 from this patch it has run for over an hour now. Description (updated) ------- QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0' qpidd-p0 script binds a new port to a socket using bind(0), and then execs qpidd using the --socket-fd option to pass the socket to qpidd. Changes: - Added qpidd-p0 - Fixed qpidd port printing logic: print port only if --port=0, regardless of --transport. - New option --listen-disable to disable specific transport listeners. WIP: astitcher disable-transpor from https://reviews.apache.org/r/10894/ Diffs (updated) ----- /trunk/qpid/cpp/src/posix/QpiddBroker.cpp 1478313 /trunk/qpid/cpp/src/qpid/broker/Broker.h 1478313 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1478313 /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1478313 /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1478313 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1478313 /trunk/qpid/cpp/src/tests/Makefile.am 1478313 /trunk/qpid/cpp/src/tests/qpidd-p0 PRE-CREATION Diff: https://reviews.apache.org/r/10872/diff/ Testing ------- make check Thanks, Alan Conway
