On 16 December 2013 18:54, Alan Conway <acon...@redhat.com> wrote: > On 12/15/2013 02:59 PM, Robbie Gemmell wrote: > >> Hi all, >> >> Please find the RAT output for 0.26rc1 at: >> http://people.apache.org/~robbie/qpid/0.26/0.26rc1_rat_output.txt >> >> There are a number of files needing attention in the cpp, doc, and java >> trees. Many of the latter ones were flagged for 0.24, so we must have only >> fixed them on the branch and not on trunk. >> >> I will look at getting the doc and java trees fixed tomorrow, if someone >> could look at the others that would be good. >> >> Robbie >> >> > The following are fixed on trunk and 0.26. There were some problem files, > see below. > > cpp/AMQP_1.0 > cpp/DESIGN > cpp/INSTALL-WINDOWS > cpp/README-HA.txt > cpp/README-winsdk.txt > cpp/SSL > cpp/cmake_uninstall.cmake.in > cpp/design_docs/ha-transactions.md > cpp/design_docs/log-model-category-for-correlation.txt > cpp/design_docs/windows_clfs_store_design.txt > cpp/docs/man/qpidd.1 > cpp/docs/man/qpidd.x > cpp/docs/src/CONTENTS > cpp/etc/cluster.conf-example.xml.in > cpp/examples/test.txt > cpp/src/check-abi > cpp/src/libqpidmessaging-api-symbols.txt > cpp/src/libqpidtypes-api-symbols.txt > cpp/src/qpid/ha/README.md > cpp/src/qpid/linearstore/ISSUES > cpp/src/qpid/linearstore/jrnl/utils/rec_hdr.c > cpp/src/tests/config.null > cpp/src/tests/failing-amqp0-10-python-tests > cpp/src/tests/failing-amqp1.0-python-tests > cpp/src/tests/policy.acl > cpp/src/tests/qpidd-empty.conf > cpp/src/tests/linearstore/linearstoredirsetup. > > > > This one already has an AMQP working group copyright notice, is it OK to > shove an apache notice in front? > > cpp/specs/amqp.0-10-qpid-errata.stripped.xml - AMQP working group >
Probably not, but you dont need to since it is already licenced, just not with ALv2 (because we are reusing the original). > > The following are processed by various programs, I don't know if there's a > safe comment syntax. Can we get an exemption for such files? > > QPID_VERSION.txt > cpp/QPID_VERSION.txt > The above seem reasonable as they contain only a version number. The below I would guess depends on what is in them and how they are used, none of which I have any knowledge of I'm afraid. > cpp/src/qpid.linkmap > cpp/src/qmf2.pc.in > cpp/src/qpid.pc.in > cpp/src/tests/.valgrind.supp > cpp/src/tests/test.xquery > cpp/src/tests/legacystore/.valgrind.supp > cpp/src/tests/legacystore/.valgrindrc > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >