> On May 28, 2014, 5:18 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp, line 127 > > <https://reviews.apache.org/r/21978/diff/1/?file=597359#file597359line127> > > > > It's probably worthwhile parsing the config file so that you can set > > the ssl options there too.
That's already done in parse() I believe, not in the constructor to the SslOptions. (Or am I missing something?) > On May 28, 2014, 5:18 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp, line 137 > > <https://reviews.apache.org/r/21978/diff/1/?file=597359#file597359line137> > > > > Similarly to above. I think you could just throw "Failed to > > initialise..." + e.what(). > > > > Or even not have this in a try .. catch at all, as we no longer need to > > ensure no exceptions are thrown. I want to ensure that only exceptions of the right type are thrown. However I can rearrange this a little. > On May 28, 2014, 5:18 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp, line 152 > > <https://reviews.apache.org/r/21978/diff/1/?file=597359#file597359line152> > > > > Is it always safe to call shutdownNSS() even when initNSS() wasn't > > called? > > > > (not introduced by this change, but a possible issue nonetheless) It seems to be. It will occur whenever you exit a client that did not open any ssl connections and I haven't seen any issues with that. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21978/#review44128 ----------------------------------------------------------- On May 28, 2014, 3:36 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21978/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 3:36 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-5788 > https://issues.apache.org/jira/browse/QPID-5788 > > > Repository: qpid > > > Description > ------- > > Delay initialisation of NSS until the first SSL connection is created. This > allows env vars to be set programmatically if desired and allows forking > (provided connections are created *after* forking). > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1597730 > > Diff: https://reviews.apache.org/r/21978/diff/ > > > Testing > ------- > > make test passes > > The two test cases described in the JIRA work as expected > > > Thanks, > > Gordon Sim > >
