> On May 28, 2014, 5:18 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp, line 127 > > <https://reviews.apache.org/r/21978/diff/1/?file=597359#file597359line127> > > > > It's probably worthwhile parsing the config file so that you can set > > the ssl options there too. > > Gordon Sim wrote: > That's already done in parse() I believe, not in the constructor to the > SslOptions. (Or am I missing something?) > > Andrew Stitcher wrote: > It is done in parse, but unless the constructor tells it the file to use > (ie QPIDC_CONF_FILE) I don't see how it could figure out the file to parse.
Sorry - ignore that last comment - your original point is correct - parse *is* using the QPIDC_CONF)_FILE, but via the common options configFile member! Actually the only reason we use CommonOptions at all here is so we can override the config file from the environment variables as we don't (can't) parse the command line from here. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21978/#review44128 ----------------------------------------------------------- On May 28, 2014, 7:51 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21978/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 7:51 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-5788 > https://issues.apache.org/jira/browse/QPID-5788 > > > Repository: qpid > > > Description > ------- > > Delay initialisation of NSS until the first SSL connection is created. This > allows env vars to be set programmatically if desired and allows forking > (provided connections are created *after* forking). > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1597730 > > Diff: https://reviews.apache.org/r/21978/diff/ > > > Testing > ------- > > make test passes > > The two test cases described in the JIRA work as expected > > > Thanks, > > Gordon Sim > >
