----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21978/#review44159 -----------------------------------------------------------
I don't understand your comment about not changing the static variables to class members, as function statics will be duplicated in any forking process in exactly the same way. Function statics are really the same executable layout-wise as globals but they are only in scope in the function itself. The only difference is that for function statics that are a class type there will be some extra state and code to ensure that it is constructed thread safely only once (at least this is true for gcc and since C++11). - Andrew Stitcher On May 28, 2014, 7:51 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21978/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 7:51 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-5788 > https://issues.apache.org/jira/browse/QPID-5788 > > > Repository: qpid > > > Description > ------- > > Delay initialisation of NSS until the first SSL connection is created. This > allows env vars to be set programmatically if desired and allows forking > (provided connections are created *after* forking). > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1597730 > > Diff: https://reviews.apache.org/r/21978/diff/ > > > Testing > ------- > > make test passes > > The two test cases described in the JIRA work as expected > > > Thanks, > > Gordon Sim > >
