----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33758/#review86212 -----------------------------------------------------------
Looks good. Pretty clear what the fix is doing. proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment138134> Avoid first person pronouns in error messages. Maybe "remote channel %d is above negotiated channel_max %d." proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment138135> Next line is already 65536. Stale comment? proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment138136> s/below/above/ - Chug Rolke On June 2, 2015, 6:46 a.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33758/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 6:46 a.m.) > > > Review request for qpid, Kenneth Giusti and Ted Ross. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-842 -- channels and sessions > > > Diffs > ----- > > proton-c/include/proton/transport.h d046567 > proton-c/src/engine/engine-internal.h 2f0cc56 > proton-c/src/engine/engine.c 67cc882 > proton-c/src/transport/transport.c e72875b > tests/python/proton_tests/engine.py 924b3bc > > Diff: https://reviews.apache.org/r/33758/diff/ > > > Testing > ------- > > I originally did large system-testing using a broker and dispatch routers to > get 32K links through a single connection. > > This diff is based on what I did earlier, but improved (i think), and with a > couple mistakes corrected. Now I am testing only with proton unit tests > included with this diff, because latest dispatch is having an issue with > latest proton. > > > Thanks, > > michael goulish > >
