----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33758/#review87066 -----------------------------------------------------------
proton-c/src/engine/engine.c <https://reviews.apache.org/r/33758/#comment139337> The total number of _active_ sessions can be 1 greater than the value of channel_max. channel # can range from 0 thru channel_max. proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment139343> We may be off by one here, since the valid range of channels starts at zero and includes channel_max (limit in this code). So you want to check <= limit. proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment139335> May want to burp out a log message here so users understand why the setup failed. proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment139344> is this part of the link handle change? proton-c/src/transport/transport.c <https://reviews.apache.org/r/33758/#comment139334> still 65536 tests/python/proton_tests/engine.py <https://reviews.apache.org/r/33758/#comment139345> You should add a test that sets channel_max to some low number (say 1) and verify you can open [0..channel_max] sessions. - Kenneth Giusti On June 2, 2015, 6:46 a.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33758/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 6:46 a.m.) > > > Review request for qpid, Kenneth Giusti and Ted Ross. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-842 -- channels and sessions > > > Diffs > ----- > > proton-c/include/proton/transport.h d046567 > proton-c/src/engine/engine-internal.h 2f0cc56 > proton-c/src/engine/engine.c 67cc882 > proton-c/src/transport/transport.c e72875b > tests/python/proton_tests/engine.py 924b3bc > > Diff: https://reviews.apache.org/r/33758/diff/ > > > Testing > ------- > > I originally did large system-testing using a broker and dispatch routers to > get 32K links through a single connection. > > This diff is based on what I did earlier, but improved (i think), and with a > couple mistakes corrected. Now I am testing only with proton unit tests > included with this diff, because latest dispatch is having an issue with > latest proton. > > > Thanks, > > michael goulish > >
